[PATCH] D111048: [ARM] Introduce a MQPRCopy

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1057
+  // live out.
+  SmallPtrSet<MachineInstr *, 2> ExtraLiveOutMIs = LiveOutMIs;
+  while (!ExtraLiveOutMIs.empty()) {
----------------
samtebbs wrote:
> Rather than re-creating the live out list, would it be possible to do this MQPRCopy checking when constructing the live out list initially, or is the full list of liveouts needed before doing this checking for MQPRCopy instances?
Yeah, this code was a little odd. It is really meant to be a worklist, that we may need to add extra elements to for the copy values we treat as live-out.

I've changed it to a proper worklist. Let me know what you think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111048/new/

https://reviews.llvm.org/D111048