[PATCH] D109966: [X86][NFC] structure-return simplificiation

[Nathan Sidwell via Phabricator via llvm-commits]

urnathan updated this revision to Diff 377244.
urnathan added a comment.
Herald added a subscriber: mstorsjo.

thanks for your comments.  Moving the check-which-ABI bits into the predicate does make things much simpler.  I chose to templatize it, rather than write the same thing twice.  That does mean taking a SmallVector<T> reference, rather than ArrayRef, because template deduction.  But that ends up with less work to do anyway.  I reordered the checks to get the best short-circuiting (heuristic guesswork though).

would you prefer anonymous namespace, or stick with the static fn?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109966/new/

https://reviews.llvm.org/D109966

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109966.377244.patch
Type: text/x-patch
Size: 6538 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211005/2998b3eb/attachment.bin>