[PATCH] D109347: [JSON] Handle uint64_t type

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 07:24:59 PDT 2021


StephenTozer added a comment.

Looks mostly good, but I don't think the parsing side of things quite works: in order for us to ever parse a JSON value as an unsigned integer - including with `parse<uint64_t>` - we need to either produce unsigned `Value`s in `Parser::parseNumber`, or allow `getAsUINT64` to produce unsigned values from integer `Value`s. As there is no real way to represent unsigned values in JSON, I think the latter makes more sense as it simply needs a check to ensure that the integer value is not negative.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109347/new/

https://reviews.llvm.org/D109347



More information about the llvm-commits mailing list