[PATCH] D110939: [PHIElimination] Update LiveVariables after handling an unspillable terminator

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D110939#3041032 <https://reviews.llvm.org/D110939#3041032>, @dmgreen wrote:

> If it helps, I would expect the unspillable terminators to look like:
>
>   bb1:
>     ..
>     %r = UnspillableTerminator ..
>   bb2:
>     %p = phi %r, ...
>     ... uses of %p
>
> In our usecase in the Arm backend, bb2 will be a loop header, usually with a single block (but not necessarily, especially in the future).

In the tests I am looking at, there is a preheader block in between your bb1 and bb2, and %r is live-through the preheader.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110939/new/

https://reviews.llvm.org/D110939