[PATCH] D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand
Stephen Tozer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 5 03:08:09 PDT 2021
StephenTozer added a comment.
Very nice cleanup!
> Also curious if invariant debug register operands are applicable to other debug instructions (DBG_INSTR_REF, DBG_PHI, DBG_LABEL)
I think that this change should probably include `DBG_PHI`s as well - you could probably just replace `isDebugValue()` with `isDebugInstr()`, as any current or future debug instructions that use registers should have them set `isDebug`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110105/new/
https://reviews.llvm.org/D110105
More information about the llvm-commits
mailing list