[PATCH] D110922: [LoopPeel] Peel loops with deoptimizing exits

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BasicBlockUtils.cpp:502
+        isa<UnreachableInst>(BB->getTerminator()))
+      return true;
+    BB = BB->getSingleSuccessor();
----------------
mkazantsev wrote:
> There is one thing that bugs me. Imagine a sutiation:
> ```
> loop_exit:
>   call foo() // will not return, but is not a deopt
>   unreachable
> ```
> 
> I'm not sure if it's bad actually. But maybe we should consider checking all other (non deopt) instruction with `isGuaranteedToTransferExecutionToSuccessor`. Opinions?
This is actually exactly the situation would have wanted to ask to be supported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110922/new/

https://reviews.llvm.org/D110922