[PATCH] D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC)

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 00:12:51 PDT 2021


aheejin added inline comments.


================
Comment at: lld/wasm/Relocations.cpp:35
 static bool allowUndefined(const Symbol* sym) {
   // Undefined functions and globals with explicit import name are allowed to be
   // undefined at link time.
----------------
Now that this function does not specifically target globals, is this comment correct? Can data or tables have explicit import names and return `true` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111101/new/

https://reviews.llvm.org/D111101



More information about the llvm-commits mailing list