[PATCH] D79794: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction.

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

> The design was already messed up before INLINEASM_BR for exception handling.

To me, this is the main point.

Given the existing handling for invoke, I still believe that using the same underlying mechanisms for inlineasm_br was the best implementation choice, because inlineasm_br behaves almost exactly like an invoke with a user-defined custom calling convention.

If you can come up with a proposal to handle invoke differently, then I expect inlineasm_br should fit easily into that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79794/new/

https://reviews.llvm.org/D79794