[PATCH] D111098: [LICM] Bail if checking a global/constant for invariant.start

Mon Oct 4 13:54:56 PDT 2021

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM, this matches what we do elsewhere.

================
Comment at: llvm/test/Transforms/LICM/hoisting.ll:605

-; FIXME: Don't hoist invariant loads of globals.
+; Don't hoist invariant loads of globals.
 define void @test_fence6() {
----------------
This makes it sound like there's a correctness (or at least profitability) reason not to hoist these, while ultimately this is only a technical limitation (right?) I'd make this "Hoisting invariant loads of globals is currently not supported" or invert the fixme to "FIXME: Support hoisting invariant loads of globals".

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111098/new/

https://reviews.llvm.org/D111098