[PATCH] D110900: Triple: Add RedHat vendor

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 4 13:30:15 PDT 2021


hvdijk added a comment.

This whole thing feels a bit wrong to me, but if we need something like this, there's three things that stand out to me. Firstly, @aaronpuchert already commented that SUSE has the same issue, so this shouldn't be limited to Red Hat. Depending on what GCC does, possibly even things like `x86_64-linux` and `x86_64-unknown-linux` should be treated as `x86_64-unknown-linux-gnu`. Maybe the vendor check could just be removed entirely? Secondly, we appear to not distinguish between unknown environment and missing environment, this should probably only be done for missing environment. That is, we probably shouldn't start treating `x86_64-linux-uclibc`, which we do not support, as `x86_64-linux-gnu`. Thirdly, this should almost certainly have a check for OS, we should only be doing this for Linux.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110900/new/

https://reviews.llvm.org/D110900



More information about the llvm-commits mailing list