[PATCH] D108741: [IR][GlobalDCE] Add ability to mark vtable methods as eligible for VFE and avoid eliminating non-eligible vfunc in VFE in GlobalDCE

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek marked an inline comment as done.
kubamracek added inline comments.


================
Comment at: llvm/docs/TypeMetadata.rst:289
+1. All virtual function pointers in the vtable must be wrapped in a
+   ``vfe_eligible`` constant. Function pointers without a ``vfe_eligible``
+   marker are not participating in removal of unused function pointers. See
----------------
fhahn wrote:
> IIUC the `must` here seems to be stronger than it needs to be. Pointers in the vtable *can* be wrapped as `vie_eligible` to consider them for virtual function elimination. But if they aren't, it is still a valid vtable, right?
Rephrased.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108741/new/

https://reviews.llvm.org/D108741