[PATCH] D111086: [WebAssembly] Remove WasmTagType

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Nice!



================
Comment at: lld/wasm/InputFiles.cpp:499
   ArrayRef<uint32_t> funcTypes = wasmObj->functionTypes();
+  ArrayRef<uint32_t> tagTypes = wasmObj->tagTypes();
   ArrayRef<WasmSignature> types = wasmObj->types();
----------------
Why have a separate  `tagTypes()` method?  Wouldn't be better just add `Type` o `Sig` to `struct WasmTag`? 


================
Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:120
   union {
     uint32_t SigIndex;
     WasmGlobalType Global;
----------------
So is this element of the union is now be used for tags? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111086/new/

https://reviews.llvm.org/D111086