[PATCH] D110294: [DebugInfo] Fix debug info for imported declarations of inlined functions

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

I don't think this is the right approach - because it depends on the abstract SP being created before the query - and would produce a different result if the abstract SP is created after the query. Abstract SPs are created only once an inlined subroutine is discovered, I believe - so the DWARF would be different depending on function ordering - in some cases having things attached to the abstract DIE, in some cases to the concrete DIE. That's not ideal.

Looking at the callers, for instance - constructCallSiteEntryDIE looks like it could have that issue with the new getOrCreateSubprogramDIE behavior - depending on whether the call site is before or after the first inlining of the caller, the DWARF would point to the abstract origin or the (possibly incorrect/invalid/weird-empty) concrete subprogram DIE, perhaps?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110294/new/

https://reviews.llvm.org/D110294