[PATCH] D110939: [PHIElimination] Update LiveVariables after handling an unspillable terminator

Mon Oct 4 03:38:02 PDT 2021

foad added a comment.

In D110939#3039375 <https://reviews.llvm.org/D110939#3039375>, @dmgreen wrote:

> This sounds conceptually OK to me - that we would need to update the live variables for unspillable terminators - but I don't know a lot about updating LV, so don't know a lot of the details.
>
> Should the Incoming blocks be the Src blocks, or should it be a combination of Incoming and Src?

I think at this point IncomingReg is a freshly created register, so it won't have any AliveBlocks yet.

Having said that I admit I don't understand all the details either, I was just doing the minimum to get verification to pass, since my next project is to remove LiveVariables anyway in favour of LiveIntervals.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110939/new/

https://reviews.llvm.org/D110939