[PATCH] D110318: [Support] Restore LLVMTestingSupport as an llvm component library

[Itay Bookstein via Phabricator via llvm-commits]

nextsilicon-itay-bookstein added a comment.

I think that an llvm 'component library' is a logical library that llvm exposes outwards. 
It becomes query-able from `llvm-config`, and it declares other components it depends on for internal dependency management, which is then exposed outwards also.
For example, when I invoke `llvm-config --ldflags --libs testingsupport`, after the fix, I get this output:

  -L/path/to/build/dir/lib
  -lLLVMTestingSupport -lLLVMSupport -lLLVMDemangle

Without the fix, I get the warning `"testingsupport library not installed, some tests will be skipped"` warning, because then `llvm-config` cannot find it in the `llvm-config --ldflags --libs testingsupport` invocation in `CompilerRTUtils.cmake`.
As far as I can tell, the `add_llvm_component_library` function passes the `BUILDTREE_ONLY` argument through to `add_llvm_library`, which then controls whether it will get installed or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110318/new/

https://reviews.llvm.org/D110318