[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 27 07:42:42 PDT 2021


yaxunl added a comment.

Pls update the description of the patch and also make sure it passes internal CI.



================
Comment at: clang/test/CodeGenCUDA/amdgpu-alias-undef-symbols.cu:1
+// RUN: %clang --offload-arch=gfx906 --cuda-device-only -x hip -emit-llvm -S -o - %s \
+// RUN:   -fgpu-rdc -O3 -mllvm -amdgpu-early-inline-all=true -mllvm -amdgpu-function-calls=false | \
----------------
this test needs

// REQUIRES: amdgpu-registered-target, clang-driver


================
Comment at: llvm/test/CodeGen/AMDGPU/inline-calls.ll:2-3
 ; RUN: llc -march=amdgcn -mcpu=tahiti -verify-machineinstrs < %s | FileCheck  %s
-; RUN: llc -march=amdgcn -mcpu=tonga -verify-machineinstrs < %s | FileCheck  %s
-; RUN: llc -march=r600 -mcpu=redwood -verify-machineinstrs < %s | FileCheck %s
 
----------------
why these two lines are removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109707/new/

https://reviews.llvm.org/D109707



More information about the llvm-commits mailing list