[PATCH] D111029: [X86] Prefer 512-bit vectors on Ice/Rocket/TigerLake (PR48336)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 3 11:13:10 PDT 2021


RKSimon created this revision.
RKSimon added reviewers: pengfei, craig.topper, pcordes.
Herald added a subscriber: hiraditya.
RKSimon requested review of this revision.
Herald added a project: LLVM.

This patch proposes we drop the TuningPrefer256Bit tuning flag on IceLake and later.

It doesn't appear that IceLake and later CPUs have the drastic frequency scaling issues with 512-bit vector usage, unlike earlier AVX512-capable targets: https://travisdowns.github.io/blog/2020/08/19/icl-avx512-freq.html

I'm uncertain if there are any locations in the source that need to kept in sync with this change, but I didn't find anything in a brief search.

I'm open to suggestions on additional test coverage, we have tried to make new costmodel/vectorizer tests to be attribute based instead of specifying cpus but it might be useful to add some -mcpu=icelake coverage here?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111029

Files:
  llvm/lib/Target/X86/X86.td
  llvm/test/CodeGen/X86/min-legal-vector-width.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111029.376773.patch
Type: text/x-patch
Size: 130923 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211003/d8f60d31/attachment-0001.bin>


More information about the llvm-commits mailing list