[PATCH] D111005: [LSV] Change the default value of InstertElement to poison

[Hyeongyu Kim via Phabricator via llvm-commits]

hyeongyukim added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:1131
         Value *Insert =
             Builder.CreateInsertElement(Vec, Extract, Builder.getInt32(NewIdx));
         Vec = Insert;
----------------
if `StoreTy` is `FixedVectorType`, the poison will be hided by this `CreateInsertElement.`
Since `VecTy`'s length is `Chain.size() * VecStoreTy->getNumElements()`, all poisons will be hidden.


================
Comment at: llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:1144
       Value *Insert =
           Builder.CreateInsertElement(Vec, Extract, Builder.getInt32(I));
       Vec = Insert;
----------------
if `StoreTy` is not `FixedVectorType`, the poison will be hided by this `CreateInsertElement.`
Since `VecTy`'s length is `Chain.size()`, all poisons will be hidden.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111005/new/

https://reviews.llvm.org/D111005