[compiler-rt] d6a4294 - Use standard separator for TSan options in `stress.cpp` test case.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 2 21:11:30 PDT 2021


Author: Dan Liew
Date: 2021-10-02T21:11:18-07:00
New Revision: d6a4294d1362b37f07a96c8ca6d18e260d44bcd6

URL: https://github.com/llvm/llvm-project/commit/d6a4294d1362b37f07a96c8ca6d18e260d44bcd6
DIFF: https://github.com/llvm/llvm-project/commit/d6a4294d1362b37f07a96c8ca6d18e260d44bcd6.diff

LOG: Use standard separator for TSan options in `stress.cpp` test case.

Use of space as a separator for options is problematic for wrapper
scripts (i.e. implementations of `%run`) that have to marshall
environment variables to target different than the host.

Rather than requiring every implementation of `%run` to support spaces
in `TSAN_OPTIONS` it is simpler to fix this single test case.

rdar://83637067

Differential Revision: https://reviews.llvm.org/D110967

Added: 
    

Modified: 
    compiler-rt/test/tsan/stress.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/tsan/stress.cpp b/compiler-rt/test/tsan/stress.cpp
index d678395fd8dfd..3656223b17ae2 100644
--- a/compiler-rt/test/tsan/stress.cpp
+++ b/compiler-rt/test/tsan/stress.cpp
@@ -1,4 +1,4 @@
-// RUN: %clangxx_tsan -O1 %s -o %t && %env_tsan_opts="flush_memory_ms=1 flush_symbolizer_ms=1 memory_limit_mb=1" %run %t 2>&1 | FileCheck %s
+// RUN: %clangxx_tsan -O1 %s -o %t && %env_tsan_opts=flush_memory_ms=1:flush_symbolizer_ms=1:memory_limit_mb=1 %run %t 2>&1 | FileCheck %s
 #include "test.h"
 #include <fcntl.h>
 #include <string.h>


        


More information about the llvm-commits mailing list