[PATCH] D109845: [SCEV] Correctly propagate nowrap flags across scopes when folding invariant add through addrec

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:6598
+    return &*F.getEntryBlock().begin();
+  }
   return nullptr;
----------------
nikic wrote:
> Might make sense to just make `&*F.getEntryBlock().begin()` the fallback return value? That one should hold for all SCEVs, not just SCEVConstant in particular.
Hm, with the current code structure, you're right.  Once I build the recursion interface, I'll want to go back to the nullptr form (as a signal to recurse), but this is a good idea.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109845/new/

https://reviews.llvm.org/D109845