[PATCH] D110971: [X86][Costmodel] Load/store i8 Stride=4 VF=32 interleaving costs

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D110971#3038020 <https://reviews.llvm.org/D110971#3038020>, @lebedev.ri wrote:

> In D110971#3038014 <https://reviews.llvm.org/D110971#3038014>, @RKSimon wrote:
>
>> LGTM
>
> Thank you so much for the reviews!
>
> By now, i have to ask.
> By now, all but one preexisting entries in `AVX2InterleavedLoadTbl`/`AVX2InterleavedStoreTbl` tables have been redone.
> This has covered my most immediate interest. Has a saturation point been reached with these reviews,
> in the sense that reviewing them become a painful boring tedious expirience? If so, i could stop here.
> If not, there are a few more i could add..

Hm, looks like i lied, i still need to add a few more, even when looking just at the darktable:

  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i16 Stride = 3 VF = 16 Indices.size() = 3
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i16 Stride = 3 VF = 2 Indices.size() = 3
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i16 Stride = 3 VF = 4 Indices.size() = 3
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i16 Stride = 3 VF = 8 Indices.size() = 3
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i32 Stride = 3 VF = 2 Indices.size() = 3
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i32 Stride = 3 VF = 4 Indices.size() = 3
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i32 Stride = 3 VF = 8 Indices.size() = 3
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i32 Stride = 4 VF = 2 Indices.size() = 4
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i32 Stride = 4 VF = 4 Indices.size() = 4
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i32 Stride = 4 VF = 8 Indices.size() = 4
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i32 Stride = 6 VF = 2 Indices.size() = 6
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i32 Stride = 6 VF = 4 Indices.size() = 6
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i32 Stride = 6 VF = 8 Indices.size() = 6
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i8 Stride = 6 VF = 2 Indices.size() = 6
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i8 Stride = 6 VF = 4 Indices.size() = 6
  X86TTIImpl::getInterleavedMemoryOpCostAVX2():  EltTy = i8 Stride = 6 VF = 8 Indices.size() = 6


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110971/new/

https://reviews.llvm.org/D110971