[PATCH] D110634: [llvm] Update IR verifier to reject non-power-of-2 alignment assume bundles (PR48713).

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D110634#3038162 <https://reviews.llvm.org/D110634#3038162>, @nikic wrote:

> Marking this as changes requested, because we have to either forbid non-constants, or we have to give up on this approach and say that consuming code needs to expect and handle invalid alignments. I don't think there's any in-between options here.

I don't think the argument against an in-between option is actually something we have to worry about. As mentioned before, the only impact is that we would reject problematic code later rather than never.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110634/new/

https://reviews.llvm.org/D110634