[PATCH] D109114: [GlobalDCE] In VFE, replace the whole 'sub' expression of unused relative-pointer-based vtable slots

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added a comment.

> Yeah moving the matcher code to a function might help, as well as moving them next to each other.

Done.

> Sounds good, can you add a message/comment to the assert?

Done.

>> Attempted to do this, but it complicates the implementation. Not sure if the extra complexity is worth it (we only save an extra iteration over vtables, and presumably in realistic programs that's a limited amount of those).
>
> Agreed that it might not be too important, I'm fine with either.

Moved back to iterating over users twice, I think the benefits of avoiding the extra work are small and probably not worth the complexity.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109114/new/

https://reviews.llvm.org/D109114