[PATCH] D109407: [InlineAsm] Support call function label in x86 inline asm with PIC

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp:1441
         // operands to the machine instruction.
-        for (unsigned j = 0; j != NumVals; ++j, ++i)
+        for (unsigned J = 0; J != NumVals; ++J, ++i)
+          AddOperand(MIB, Node->getOperand(i), 0, nullptr, VRBaseMap,
----------------
Maybe we can use `j` here? Changing to `J` while leaving `i` looks odd.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp:1455
+      case InlineAsm::Kind_Imm: // Immediate.
+        for (unsigned J = 0; J != NumVals; ++J, ++i)
           AddOperand(MIB, Node->getOperand(i), 0, nullptr, VRBaseMap,
----------------
ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109407/new/

https://reviews.llvm.org/D109407