[PATCH] D110576: [Demangle] Add support for D programming language

Luís Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 1 17:29:28 PDT 2021


ljmf00 added a comment.

In D110576#3035742 <https://reviews.llvm.org/D110576#3035742>, @jhenderson wrote:

> Whilst I appreciate that it'd require a fair bit of extra work, I'm inclined to agree with @dblaikie. I don't see any exception in the contribution policy (https://llvm.org/docs/Contributing.html#how-to-submit-a-patch) for larger ports. In particular, I'm pretty sure other even larger-scale contributions from a pre-done area have had to undergo this process, so it's not a new thing.
>
> IANAL, but re. the relicensing, I guess we need some sort of formal agreement that the original author is happy for the relicensing, especially if any breakdown isn't going to end up with a significant rewrite. I suspect you should contact the LLVM board to discuss it.
>
> One other minor point, please make sure to create patches with full context (i.e. add something like -U999999 to the patch-creation command line).

I'm already partitioning this patch. When everything is arranged I'm going to post some context here. A small question: should I abandon this patch or just override the diff with a minimal implementation and stack the other patches behind?

About the licensing, should I post a thread on https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev mailing list or anywhere else? Should I CC anyone in specific too, besides Mathias and Iain?

I passed that flag on the other patches, on the latest update I forgot to add it tho, although I'm aware of that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110576/new/

https://reviews.llvm.org/D110576



More information about the llvm-commits mailing list