[PATCH] D110859: [llvm-profgen] Support symbol list for accurate profile

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 1 16:11:00 PDT 2021


wlei added a comment.

In D110859#3037131 <https://reviews.llvm.org/D110859#3037131>, @hoy wrote:

> Thanks for bringing this up. Can you make this optional under a switch? Should be on by default. Currently without a switch we have to go a round trip (ext->txt->ext) to get rid of the symbol list in an extbinary profile.

I see, thanks for pointing out, switch added.



================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:108
+  }
+  Writer->setProfileSymbolList(&SymbolList);
+
----------------
hoy wrote:
> Move this into the if block above?
Fixed!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110859/new/

https://reviews.llvm.org/D110859



More information about the llvm-commits mailing list