[PATCH] D110967: Use standard separator for TSan options in `stress.cpp` test case.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 1 13:12:59 PDT 2021


delcypher created this revision.
delcypher added reviewers: dvyukov, yln, kubamracek, aralisza.
delcypher requested review of this revision.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.

Use of space as a separator for options is problematic for wrapper
scripts (i.e. implementations of `%run`) that have to marshall
environment variables to target different than the host.

Rather than requiring every implementation of `%run` to support spaces
in `TSAN_OPTIONS` it is simpler to fix this single test case.

rdar://83637067


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110967

Files:
  compiler-rt/test/tsan/stress.cpp


Index: compiler-rt/test/tsan/stress.cpp
===================================================================
--- compiler-rt/test/tsan/stress.cpp
+++ compiler-rt/test/tsan/stress.cpp
@@ -1,4 +1,4 @@
-// RUN: %clangxx_tsan -O1 %s -o %t && %env_tsan_opts="flush_memory_ms=1 flush_symbolizer_ms=1 memory_limit_mb=1" %run %t 2>&1 | FileCheck %s
+// RUN: %clangxx_tsan -O1 %s -o %t && %env_tsan_opts=flush_memory_ms=1:flush_symbolizer_ms=1:memory_limit_mb=1 %run %t 2>&1 | FileCheck %s
 #include "test.h"
 #include <fcntl.h>
 #include <string.h>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110967.376617.patch
Type: text/x-patch
Size: 540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211001/684bc3ad/attachment.bin>


More information about the llvm-commits mailing list