[PATCH] D110864: [llvm-profgen] Ignore branch count against outline function

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 1 11:55:55 PDT 2021


hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:400
+// outlined function, we won't accumulate sample count againt it.
+static bool isOutlineFunction(StringRef CalleeName) {
+  // Skip unique linkage name.
----------------
nit: isOutlinedFunction

We should still count samples for it except for the head samples.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:404
+    return false;
+  return CalleeName.find(".") != StringRef::npos;
+}
----------------
Check against specific suffix here so that we don't overlook cases we are not aware of?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110864/new/

https://reviews.llvm.org/D110864



More information about the llvm-commits mailing list