[PATCH] D110904: [lld-macho] Check for errors when the response file doesn't exist.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo marked an inline comment as done.
oontvoo added inline comments.


================
Comment at: lld/MachO/DriverUtils.cpp:86
   // and then parse the argument again.
-  cl::ExpandResponseFiles(saver, cl::TokenizeGNUCommandLine, vec);
+  if (llvm::Error Err = cl::ExpandResponseFilesWithError(
+          saver, cl::TokenizeGNUCommandLine, vec,
----------------
thakis wrote:
> I see this is a new function. Since this will be the only caller, can we add only the arguments we need, so that we don't have to pass all these default args?
ok, will make these optional params


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110904/new/

https://reviews.llvm.org/D110904