[PATCH] D110865: X86InstrInfo: Optimize more combinations of SUB+CMP

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 1 07:09:13 PDT 2021


pengfei added inline comments.


================
Comment at: llvm/test/CodeGen/X86/optimize-compare.mir:189
+    ; 2nd CMP should be removed.
+    CMP32rr %1, %0, implicit-def $eflags
+    $bl = SETCCr 2, implicit $eflags
----------------
Do we have such CMP + CMP cases in reality? I think optimization should merged them already. The only case I can think is eflags are clobbered, so that we have to def them again which can't be optimizated here either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110865/new/

https://reviews.llvm.org/D110865



More information about the llvm-commits mailing list