[PATCH] D100651: [AIX] Support of Big archive (read)

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/include/llvm/Object/Archive.h:330
   child_iterator child_begin(Error &Err, bool SkipInternal = true) const;
+  child_iterator child_begin_bigarchive(Error &Err) const;
   child_iterator child_end() const;
----------------
DiggerLin wrote:
> I do not think we need a special child_begin_bigarchive() API for aix big ar here, 
> we can use the same API child_begin() , there is a member 
> Format in the Archive, we use have different implement of child_begin() base on the  value of "Format" , if the 
> Format is K_AIXBIG(), we have different implement of  child_begin().
also using a separate interface child_begin_bigarchive , you can not use the API

  iterator_range<child_iterator> children(Error &Err,
                                          bool SkipInternal = true) const {
    return make_range(child_begin(Err, SkipInternal), child_end());


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100651/new/

https://reviews.llvm.org/D100651