[PATCH] D110657: [BasicAA] Don't extend pointer size

Fri Oct 1 03:52:52 PDT 2021

nikic added a comment.

In D110657#3035992 <https://reviews.llvm.org/D110657#3035992>, @fhahn wrote:

>> I'd like to move this code towards always working on the correct size, and dropping these artificial pointer size adjustments is the first step towards that.
>
> I tried to add a test showing the issue in 413b7ac6b535 <https://reviews.llvm.org/rG413b7ac6b535dfb4c57c2842388a2071901b9d56>, but it still gets it wrong with this patch I think. Do you know which other parts still need adjusting?

We still need to model the actual truncation behavior. Here's my current WIP patch for that: https://gist.github.com/nikic/a9d40f6c739d60e0b6c66ce9edda4363 And there's a few more issues, e.g. our "all positive" code doesn't account for the fact that multiplying / adding positive numbers might make them non-positive.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110657/new/

https://reviews.llvm.org/D110657