[PATCH] D110912: [fir][NFC] Remove explicit num of inlined element for SmallVectors

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 1 02:35:02 PDT 2021


clementval added a comment.

In D110912#3035891 <https://reviews.llvm.org/D110912#3035891>, @awarzynski wrote:

> This makes the code follow LLVM's coding guidelines <https://llvm.org/docs/ProgrammersManual.html#llvm-adt-smallvector-h> for `SmallVector`:
>
>> In the absence of a well-motivated choice for the number of inlined elements N, it is recommended to use SmallVector<T> (that is, omitting the N).
>
> LGTM

Thanks for the quick review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110912/new/

https://reviews.llvm.org/D110912



More information about the llvm-commits mailing list