[PATCH] D108371: [LAA] Add Memory dependence and unknown bounds remarks.

[David Sherwood via Phabricator via llvm-commits]

david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM! It looks like you've addressed all the other reviewer's comments and I think the patch looks good now. Thanks!



================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2179
+      if (auto *I = dyn_cast<Instruction>(Ptr))
+        ORE->emit(recordAnalysis("UnknownArrayBounds", I)
+                  << "Unable to determine aliasing information because the "
----------------
nit: Maybe it's worth moving the recordAnalysis call to before the `for` loop, i.e.

  OptimizationRemarkAnalysis R = recordAnalysis("UnknownArrayBounds", I);
  for (...)




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108371/new/

https://reviews.llvm.org/D108371