[PATCH] D110752: [SimpleLoopUnswitch] Don't unswitch constant conditions

[Daniil Suchkov via Phabricator via llvm-commits]

DaniilSuchkov added inline comments.


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/nontrivial-unswitch-invariant-select-bug.ll:9
 ; CHECK-LABEL: @bar(
-; CHECK-NEXT:    ret i1 false
 ;
----------------
aeubanks wrote:
> DaniilSuchkov wrote:
> > aeubanks wrote:
> > > this doesn't actually happen right now?
> > Right now, since neither this patch, nor D110751 are landed, that's exactly what happens. Sorry, I forgot to add D110751 as a dependency. With that patch we get an assertion failure in this case instead of what you see in CHECKs.
> where is this diff coming from? the test isn't in tree
> could just add this test in this patch
> 
> (otherwise this patch lg)
I'll land this test with the patch (in a separate commit). I prefer to add tests separately because otherwise reviewers have to guess how the patch is connected with the test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110752/new/

https://reviews.llvm.org/D110752