[PATCH] D110818: [fir] Add fir.char_convert op

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan requested changes to this revision.
kiranchandramohan added a comment.
This revision now requires changes to proceed.

The verification tests are missing.



================
Comment at: flang/include/flang/Optimizer/Dialect/FIROps.td:473
+    ```mlir
+      fir.char_convert %1 for %2 to %3 : !fir.ref<!fir.char<1,?>>, i32, !fir.ref<!fir.char<2,20>>
+    ```
----------------
Random Comment: I think the name and syntax can be better. But not sure what it could be. I tried the following but it is also not great.

```
fir.char_copy_convert %1 to %2 count=%3 : !fir.ref<!fir.char<1,?>>, !fir.ref<!fir.char<2,20>>, i32
```


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRType.h:155
+/// Returns true iff the type `t` does not have a constant size.
+bool hasDynamicSize(mlir::Type t);
+
----------------
This function is not used or defined in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110818/new/

https://reviews.llvm.org/D110818