[PATCH] D107378: Make enum iteration with seq safe by default

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

In D107378#3034620 <https://reviews.llvm.org/D107378#3034620>, @dblaikie wrote:

>> A couple of weeks later, I learned that seq was enhanced to support enums. But when I looked at the implementation, I learned that it blindly accepts all enum types, even though it does not make sense to iterate over all of them.
>
> Do you have a link to the patch that made that change?

I believe it was https://reviews.llvm.org/D106279.

> Any references to problems created (bugs introduced/patches that fix those bugs, etc) by that more liberal change compared to the direction in this patch?

This API looks inherently unsafe to me. However, I'm not aware of any existing bugs caused by it in LLVM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107378/new/

https://reviews.llvm.org/D107378