[PATCH] D110752: [SimpleLoopUnswitch] Don't unswitch constant conditions

[Daniil Suchkov via Phabricator via llvm-commits]

DaniilSuchkov added a comment.

In D110752#3034962 <https://reviews.llvm.org/D110752#3034962>, @aeubanks wrote:

> rebasing this on D110751 <https://reviews.llvm.org/D110751> is confusing, especially since the test is XFAIL in that patch
> I'd just add the test and run update_test_checks.py on it in this patch
>
> then just add the asserts in D110751 <https://reviews.llvm.org/D110751> in don't touch any test cases in that patch

Well, D110751 <https://reviews.llvm.org/D110751> turns the miscompile into and assertion failure, and with this patch instead of assertion failure we'll get a completely valid result.
I think this sequence of changes makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110752/new/

https://reviews.llvm.org/D110752