[PATCH] D110751: [DomTree] Assert that blocks in queries aren't from another function

Daniil Suchkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 30 14:41:22 PDT 2021


DaniilSuchkov added a comment.

In D110751#3034967 <https://reviews.llvm.org/D110751#3034967>, @aeubanks wrote:

> adding the test here is confusing, I think just adding the assert is good enough. so D110752 <https://reviews.llvm.org/D110752> would have to land first

I'm not adding the test here, it'll be in a separate patch. I want to land this patch before the D110752 <https://reviews.llvm.org/D110752> because this way it's obvious the assertion catches this bug.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110751/new/

https://reviews.llvm.org/D110751



More information about the llvm-commits mailing list