[PATCH] D109397: [AttributeList] Change indexes in AttributeList::AttrIndex

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 30 14:19:54 PDT 2021


aeubanks added a comment.

In D109397#3034403 <https://reviews.llvm.org/D109397#3034403>, @aeubanks wrote:

> the main reason I wanted to do this was to avoid the weird unsigned wrapping when doing
>
>   for (unsigned i = AL.index_begin(), e = AL.index_end(); i != e; ++i)
>
> but maybe that's not a good enough reason
>
> perhaps instead we could remove the `index_begin`/`index_end` methods and provide an iterator via something like `indexes`

https://reviews.llvm.org/D110885


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109397/new/

https://reviews.llvm.org/D109397



More information about the llvm-commits mailing list