[PATCH] D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

It may feel like I'm being a bit picky, but the prologue_end business is a bit picky, and it's helpful to have the tests be as clear as possible about what's expected.



================
Comment at: llvm/test/CodeGen/X86/line-zero-prologue-end.ll:4
+; CHECK-NEXT: .file{{.+}}
+; CHECK-NEXT: .loc 1 2 0
+; CHECK-NEXT: .cfi_startproc
----------------
Should this have prologue_end on it?


================
Comment at: llvm/test/CodeGen/X86/line-zero-prologue-end.ll:7
+; CHECK-NEXT: ## %bb.{{[0-9]+}}:
+; CHECK-NEXT: .loc 1 0 5 is_stmt{{.*}}
+ at x = common global i32 0, align 4
----------------
Should this check that prologue_end is *not* on it?


================
Comment at: llvm/test/CodeGen/X86/line-zero-prologue-end.ll:25
+!12 = !DILocation(line: 0, column: 5, scope: !9)
+!14 = !DILocation(line: 2, column: 1, scope: !9)
----------------
Please make !9 and !14 use different line numbers, to make it more obvious which one is the source for the .loc directive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110740/new/

https://reviews.llvm.org/D110740