[PATCH] D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z)

Mirko Brkusanin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 30 07:54:51 PDT 2021


mbrkusanin added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:379
+      MachineInstr &MI,
+      std::function<void(MachineIRBuilder &)> &MatchInfo);
+
----------------
Rename type to BuildFnTy since there is a:
using BuildFnTy = std::function<void(MachineIRBuilder &)>;

(same for other patches as well, might help with formatting)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93305/new/

https://reviews.llvm.org/D93305



More information about the llvm-commits mailing list