[PATCH] D108136: [LoopVectorize] Permit vectorisation of more select(cmp(), X, Y) reduction patterns

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 30 07:08:09 PDT 2021


kmclaughlin accepted this revision.
kmclaughlin added a comment.
This revision is now accepted and ready to land.

Thanks for addressing my comments @david-arm, the changes look good to me.



================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:955
+    return getRecurrenceStartValue();
+    break;
   default:
----------------
Can this `break` be removed since we're returning above it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108136/new/

https://reviews.llvm.org/D108136



More information about the llvm-commits mailing list