[PATCH] D98932: [RISCV] Don't call setHasMultipleConditionRegisters(), so icmp is sunk

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 30 06:03:50 PDT 2021


jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/sink-icmp.ll:4
+; RUN:   | FileCheck -check-prefix=RV32I %s
+; RUN: llc -mtriple=riscv32 -mattr=+experimental-zbt -verify-machineinstrs < %s \
+; RUN:   | FileCheck -check-prefix=RV32IBT %s
----------------
jrtc27 wrote:
> The RVxxI and RVxxIBT CHECK lines look identical?
> 
> It's also not clear what this test is trying to test, could you please add a short summary to it so people know what regressions to look for?
(though maybe seeing the diff for this would make that obvious and any regressions would be similarly obvious?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98932/new/

https://reviews.llvm.org/D98932



More information about the llvm-commits mailing list