[PATCH] D110786: [GlobalISel] Extend G_SELECT of known condition combine to vectors.

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:1028
+    return None;
+  return APInt(64, *RegOrCst, true);
+}
----------------
`64` seems a bit imprecise here. Can't we handle the scalar and vector cases consistently, either using APInt throughout **or** int64_t throughout?


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/combine-select.mir:3
 # RUN: llc -run-pass=aarch64-prelegalizer-combiner -verify-machineinstrs -mtriple aarch64-unknown-unknown %s -o - | FileCheck %s
-# RUN: llc -debugify-and-strip-all-safe -run-pass=aarch64-prelegalizer-combiner -verify-machineinstrs -mtriple aarch64-unknown-unknown %s -o - | FileCheck %s
+# R UN: llc -debugify-and-strip-all-safe -run-pass=aarch64-prelegalizer-combiner -verify-machineinstrs -mtriple aarch64-unknown-unknown %s -o - | FileCheck %s
 ---
----------------
Unintended change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110786/new/

https://reviews.llvm.org/D110786