[PATCH] D110805: [MLIR] Fix unused tablegen template arg warnings

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 30 02:35:42 PDT 2021


c-rhodes created this revision.
c-rhodes added reviewers: rriddle, rsuderman, mehdi_amini, silvas.
Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, armkevincheng, jsmolens, eric-k256, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen.
Herald added a reviewer: antiagainst.
Herald added a reviewer: sjarus.
c-rhodes requested review of this revision.
Herald added subscribers: stephenneuendorffer, nicolasvasilache.
Herald added a project: MLIR.

Identified in D109359 <https://reviews.llvm.org/D109359>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110805

Files:
  mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td
  mlir/include/mlir/IR/OpBase.td


Index: mlir/include/mlir/IR/OpBase.td
===================================================================
--- mlir/include/mlir/IR/OpBase.td
+++ mlir/include/mlir/IR/OpBase.td
@@ -2083,8 +2083,7 @@
 // declarations should be generated. This class takes an optional set of methods
 // that should have declarations generated even if the method has a default
 // implementation.
-class DeclareInterfaceMethods<Interface interface,
-                              list<string> overridenMethods = []> {
+class DeclareInterfaceMethods<list<string> overridenMethods = []> {
     // This field contains a set of method names that should always have their
     // declarations generated. This allows for generating declarations for
     // methods with default implementations that need to be overridden.
@@ -2092,7 +2091,7 @@
 }
 class DeclareAttrInterfaceMethods<AttrInterface interface,
                                   list<string> overridenMethods = []>
-      : DeclareInterfaceMethods<interface, overridenMethods>,
+      : DeclareInterfaceMethods<overridenMethods>,
         AttrInterface<interface.cppClassName> {
     let description = interface.description;
     let cppClassName = interface.cppClassName;
@@ -2101,7 +2100,7 @@
 }
 class DeclareOpInterfaceMethods<OpInterface interface,
                                 list<string> overridenMethods = []>
-      : DeclareInterfaceMethods<interface, overridenMethods>,
+      : DeclareInterfaceMethods<overridenMethods>,
         OpInterface<interface.cppClassName> {
     let description = interface.description;
     let cppClassName = interface.cppClassName;
@@ -2110,7 +2109,7 @@
 }
 class DeclareTypeInterfaceMethods<TypeInterface interface,
                                   list<string> overridenMethods = []>
-      : DeclareInterfaceMethods<interface, overridenMethods>,
+      : DeclareInterfaceMethods<overridenMethods>,
         TypeInterface<interface.cppClassName> {
     let description = interface.description;
     let cppClassName = interface.cppClassName;
Index: mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td
===================================================================
--- mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td
+++ mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td
@@ -149,7 +149,7 @@
      AnyTypeOf<types>.predicate,
      VectorOf<types>.predicate,
      TensorOf<types>.predicate]>,
-     "signless-integer-32-like">;
+     description>;
 
 def Tosa_Int8Like : Tosa_TypeLike<[Tosa_Int8], "signless-integer-8-bit-like">;
 def Tosa_Int16Like : Tosa_TypeLike<[Tosa_Int16], "signless-integer-16-bit-like">;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110805.376141.patch
Type: text/x-patch
Size: 2608 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210930/afaf67f1/attachment.bin>


More information about the llvm-commits mailing list