[PATCH] D110412: [fir] Update fir.allocmem op

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:184
       intype.isa<PointerType>() || intype.isa<FunctionType>())
     return {};
   return HeapType::get(intype);
----------------
mehdi_amini wrote:
> I'm not sure about using this in the builder API?
> It seems like it'll yield confusing errors at runtime, could this be just an assert here instead?
> 
> `assert(intype.isa<ReferenceType, HeapType, PointerType, FunctionType>());`
> 
> ((the assert may be already in the HeadType ctor by the way)
Right. I'll make a separate patch for this. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110412/new/

https://reviews.llvm.org/D110412