[PATCH] D110577: [llvm-cxxfilt] Enable support for D programming language demangling

Thu Sep 30 00:14:10 PDT 2021

jhenderson accepted this revision.
jhenderson added inline comments.

================
Comment at: llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp:21
 #include <cstdlib>
+#include <cstring>
 #include <iostream>
----------------
ljmf00 wrote:
> jhenderson wrote:
> > I don't think you need to include this header - `strncmp` is already used in this file, so it's clearly being included through the existing include hierarchy. See also https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible.
> Yeah, my editor LSP plugin probably added it automatically by mistake, and no apparent duplication was detected. I'm going to remove it!
No problem!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110577/new/

https://reviews.llvm.org/D110577