[PATCH] D110747: [NFC] Restore magic and magicu to a globally visible location

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 15:36:36 PDT 2021


ctetreau updated this revision to Diff 376055.
ctetreau added a comment.

address code review issues:

- fix include guard
- rename `mag` to `Retval`
- also, make all the variables PascalCase to silence clang-tidy


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110747/new/

https://reviews.llvm.org/D110747

Files:
  llvm/include/llvm/Support/DivisionByConstantInfo.h
  llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/DivisionByConstantInfo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110747.376055.patch
Type: text/x-patch
Size: 13837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210929/bfcd0445/attachment.bin>


More information about the llvm-commits mailing list