[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

[Haowei Wu via Phabricator via llvm-commits]

haowei added a comment.

We are seeing a series of weird errors in our windows clang builder after this patch landed:

  [1/828] Building CXX object compiler-rt\lib\sanitizer_common\CMakeFiles\RTSanitizerCommonNoTermination.x86_64.dir\sanitizer_solaris.cpp.obj
  FAILED: compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoTermination.x86_64.dir/sanitizer_solaris.cpp.obj 
  C:\b\s\w\ir\x\w\staging\llvm_build\.\bin\clang-cl.exe  /nologo -TP -DHAVE_RPC_XDR_H=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__func__=__FUNCTION__ -IC:\b\s\w\ir\x\w\llvm-project\compiler-rt\lib\sanitizer_common\.. /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /bigobj /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /Z7 /O2 /Ob1    /Zc:threadSafeInit- -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta /Z7 -UNDEBUG /showIncludes /Focompiler-rt\lib\sanitizer_common\CMakeFiles\RTSanitizerCommonNoTermination.x86_64.dir\sanitizer_solaris.cpp.obj /Fdcompiler-rt\lib\sanitizer_common\CMakeFiles\RTSanitizerCommonNoTermination.x86_64.dir\ -c C:\b\s\w\ir\x\w\llvm-project\compiler-rt\lib\sanitizer_common\sanitizer_solaris.cpp
  error: unknown argument: '-wd4141'
  error: unknown argument: '-wd4146'
  error: unknown argument: '-wd4244'
  error: unknown argument: '-wd4267'
  error: unknown argument: '-wd4291'
  error: unknown argument: '-wd4351'
  error: unknown argument: '-wd4456'
  error: unknown argument: '-wd4457'
  error: unknown argument: '-wd4458'
  error: unknown argument: '-wd4459'
  error: unknown argument: '-wd4503'
  error: unknown argument: '-wd4624'
  error: unknown argument: '-wd4722'
  error: unknown argument: '-wd4127'
  error: unknown argument: '-wd4512'
  error: unknown argument: '-wd4505'
  error: unknown argument: '-wd4610'
  error: unknown argument: '-wd4510'
  error: unknown argument: '-wd4702'
  fatal error: too many errors emitted, stopping now [-ferror-limit=]

Failed build task is https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8834735134024529217/overview . The error disappeared when I revert this change on our builder. Do you have an idea why this change caused the build issue?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110668/new/

https://reviews.llvm.org/D110668